Date: Thu, 28 Aug 2014 10:54:04 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193061] stage-fy japanese/eijiro-fpw Message-ID: <bug-193061-13-2RrQrBZc19@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193061-13@https.bugs.freebsd.org/bugzilla/> References: <bug-193061-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193061 --- Comment #8 from John Marino <marino@FreeBSD.org> --- (In reply to turutani from comment #7) > I do not know about this... > As far as I know, some versions of CD-ROM are sold. > At least one of them (which I have) contains compressed data with > self-extracting lha archive file, having .exe suffix. Okay, I looked closer and it's trying to handle both cases (either compressed, or uncompressed eijiro52.txt. Let's just make this Makefile simpler: A) Make lha an unconditional EXTRACT_DEPENDS, and move it where the first EXTRACT_DEPENDS is defined. B) Get rid of ${CDROM_PATH} completely as well as the DIST_ARCHIVE check the SRCFILE is always going to end up in WRKDIR directory, so change MAKE_ARGS+= SRCFILE=${WRKDIR}/${SRCFILE} Then we can leave the post-extract target mostly how it is now. [1] Doing it this way makes it simpler, removes the shell command, and the only downside is an unused dependency on lha in the case of an uncompresses source file, but that's not a big penalty, right? what do you think? [1] I think "-f ${CDROM_PATH}.." changes to "-f ${DICT_pATH}.." and on the next line "-f ${DICT_PATH}/${SRCFILE}" changes to "-f ${WRKDIR}/${SRCFILE}" -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193061-13-2RrQrBZc19>