Date: Sat, 29 Jun 2013 09:36:10 -0700 From: Tim Kientzle <kientzle@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r252376 - head/lib/libutil Message-ID: <A89C1472-264E-4B9C-8711-763ED156E9D2@FreeBSD.org> In-Reply-To: <20130629161914.GD91021@kib.kiev.ua> References: <201306291552.r5TFqnLV022460@svn.freebsd.org> <20130629161914.GD91021@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Jun 29, 2013, at 9:19 AM, Konstantin Belousov wrote: > On Sat, Jun 29, 2013 at 03:52:49PM +0000, Tim Kientzle wrote: >> Author: kientzle >> Date: Sat Jun 29 15:52:48 2013 >> New Revision: 252376 >> URL: http://svnweb.freebsd.org/changeset/base/252376 >> >> Log: >> Fix -Wunsequenced warning > What is this ? From the name of the warning, it sounds as if the problem > is in the lack of sequence point between two modifications of the same > variable in the expression ? > > But, there function' argument evaluation and function call are separated > by seq point, AFAIR. Could you, please, clarify ? I think you're right about that, though I'd have to look at the spec to be sure. Not sure why clang would report this as a -Wunsequenced warning. The implied store here is certainly redundant, though. Tim >> Submitted by: dt71@gmx.com >> >> Modified: >> head/lib/libutil/login_times.c >> >> Modified: head/lib/libutil/login_times.c >> ============================================================================== >> --- head/lib/libutil/login_times.c Sat Jun 29 15:51:27 2013 (r252375) >> +++ head/lib/libutil/login_times.c Sat Jun 29 15:52:48 2013 (r252376) >> @@ -96,7 +96,7 @@ parse_lt(const char *str) >> else >> m.lt_start = 0; >> if (*p == '-') >> - p = parse_time(++p, &m.lt_end); >> + p = parse_time(p + 1, &m.lt_end); >> else >> m.lt_end = 1440; >> > [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) iQEcBAEBAgAGBQJRzwz7AAoJEGMNyGo0rfFB35QH/1wG9cBd+d/SMmk8clA9uZPF 4AQykeKwhjptBt37tDGq6P1I2RYhInGdBJO4LEXAvhCJSO24yzXpDIhg9CF+71+T 213/i5hkvHYjCsQlyeGoJkXOo79FkjFz7D7sgHUXxYta/Hnx4DizSORzv5aW7hHP KVLGZbCDE1ifXEl2oO4AnuZjB3Ed0iHxSKOMpE37SnghZhz/BUcy77WsEB0Eoo6Y pbvHYeGxYNBzmYf/tvyyNQZ9Ua0lmCqhqi0xazJJnV1KsxUEzG5KST3EHD2GBIb2 g6WCcjVkA7bskegUFtoAoKKWxl+zqtXckHlG1IkpkMQHMOVWF/18jUDwdDsY1l8= =d9g7 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A89C1472-264E-4B9C-8711-763ED156E9D2>