Date: Sun, 4 Sep 2016 22:36:03 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305392 - head/sys/conf Message-ID: <000B5E66-D804-4317-9957-8BDEDBD6B7F6@FreeBSD.org> In-Reply-To: <CAG6CVpUsC9DqCKVjXgCH99fpGukhZRYw3OnG-_WzqsX-ahGDpw@mail.gmail.com> References: <201609041755.u84HtMa5060050@repo.freebsd.org> <CAG6CVpU%2BeWvmdC-VzZ6jtQaUydsH4=9NNao8XPu2fSr0LYDgqQ@mail.gmail.com> <D294D78E-6C86-4AA2-B804-DF55D431AA91@FreeBSD.org> <CAG6CVpUsC9DqCKVjXgCH99fpGukhZRYw3OnG-_WzqsX-ahGDpw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_1F03A32E-ADC4-4716-B563-D553E7C8610C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Not in this particular case, as the section is exclusively meant for clang. Most of these warning options are completely different from gcc's. The gcc related section is just below this part in kern.mk. -Dimitry > On 04 Sep 2016, at 22:03, Conrad Meyer <cem@FreeBSD.org> wrote: >=20 > Assuming we'd like to enable building with both compilers for now, > isn't it better to use a form both accept? >=20 > Best, > Conrad >=20 > On Sun, Sep 4, 2016 at 12:31 PM, Dimitry Andric <dim@freebsd.org> = wrote: >> On 04 Sep 2016, at 20:57, Conrad Meyer <cem@FreeBSD.org> wrote: >>>=20 >>> On Sun, Sep 4, 2016 at 10:55 AM, Dimitry Andric <dim@freebsd.org> = wrote: >>>> Author: dim >>>> Date: Sun Sep 4 17:55:22 2016 >>>> New Revision: 305392 >>>> URL: https://svnweb.freebsd.org/changeset/base/305392 >>>>=20 >>>> Log: >>>> For kernel builds, instead of suppressing certain clang warnings, = make >>>> them non-fatal, so there is some incentive to fix them eventually. >>>>=20 >>>> Modified: >>>> head/sys/conf/kern.mk >>>>=20 >>>> Modified: head/sys/conf/kern.mk >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/sys/conf/kern.mk Sun Sep 4 17:50:23 2016 = (r305391) >>>> +++ head/sys/conf/kern.mk Sun Sep 4 17:55:22 2016 = (r305392) >>>> @@ -17,13 +17,13 @@ CWARNFLAGS?=3D -Wall -Wredundant-decls = -Wn >>>> # kernel where fixing them is more trouble than it is worth, or = where there is >>>> # a false positive. >>>> .if ${COMPILER_TYPE} =3D=3D "clang" >>>> -NO_WCONSTANT_CONVERSION=3D -Wno-constant-conversion >>>> -NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-shift-count-negative >>>> -NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-shift-count-overflow >>>> -NO_WSELF_ASSIGN=3D -Wno-self-assign >>>> -NO_WUNNEEDED_INTERNAL_DECL=3D = -Wno-unneeded-internal-declaration >>>> +NO_WCONSTANT_CONVERSION=3D -Wno-error-constant-conversion >>>> +NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-error-shift-count-negative >>>> +NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-error-shift-count-overflow >>>> +NO_WSELF_ASSIGN=3D -Wno-error-self-assign >>>> +NO_WUNNEEDED_INTERNAL_DECL=3D = -Wno-error-unneeded-internal-declaration >>>> NO_WSOMETIMES_UNINITIALIZED=3D -Wno-error-sometimes-uninitialized >>>> -NO_WCAST_QUAL=3D -Wno-cast-qual >>>> +NO_WCAST_QUAL=3D -Wno-error-cast-qual >>>=20 >>> I like goal of the change. Shouldn't these be -Wno-error=3Dcast-qual,= >>> etc., though? >>=20 >> That's how gcc spells them. Clang accepts both forms, there is no >> functional difference. >>=20 >> -Dimitry >>=20 --Apple-Mail=_1F03A32E-ADC4-4716-B563-D553E7C8610C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlfMhb4ACgkQsF6jCi4glqPQMACgxdHRlWFuIBabA/Dv2tbiwnod JvwAnRlpczNqvpT0/3ES5XNnRzy24mCh =KuBb -----END PGP SIGNATURE----- --Apple-Mail=_1F03A32E-ADC4-4716-B563-D553E7C8610C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?000B5E66-D804-4317-9957-8BDEDBD6B7F6>