Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 10 Jun 2012 11:17:14 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r236847 - in head/sys/dev: ahci ata mvs siis
Message-ID:  <201206101117.q5ABHEQX093676@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: mav
Date: Sun Jun 10 11:17:14 2012
New Revision: 236847
URL: http://svn.freebsd.org/changeset/base/236847

Log:
  Partially revert r236666:
  Return PROTO_ATA protocol in response to XPT_PATH_INQ.
  
  smartmontools uses it to identify ATA devices and I don't know any other
  place now where it is important. It could probably use XPT_GDEV_TYPE
  instead for more accurate protocol information, but let it live for now.
  
  Reported by:	matthew
  MFC after:	3 days

Modified:
  head/sys/dev/ahci/ahci.c
  head/sys/dev/ata/ata-all.c
  head/sys/dev/mvs/mvs.c
  head/sys/dev/siis/siis.c

Modified: head/sys/dev/ahci/ahci.c
==============================================================================
--- head/sys/dev/ahci/ahci.c	Sun Jun 10 10:40:22 2012	(r236846)
+++ head/sys/dev/ahci/ahci.c	Sun Jun 10 11:17:14 2012	(r236847)
@@ -2970,7 +2970,7 @@ ahciaction(struct cam_sim *sim, union cc
 		cpi->unit_number = cam_sim_unit(sim);
 		cpi->transport = XPORT_SATA;
 		cpi->transport_version = XPORT_VERSION_UNSPECIFIED;
-		cpi->protocol = PROTO_UNSPECIFIED;
+		cpi->protocol = PROTO_ATA;
 		cpi->protocol_version = PROTO_VERSION_UNSPECIFIED;
 		cpi->maxio = MAXPHYS;
 		/* ATI SB600 can't handle 256 sectors with FPDMA (NCQ). */

Modified: head/sys/dev/ata/ata-all.c
==============================================================================
--- head/sys/dev/ata/ata-all.c	Sun Jun 10 10:40:22 2012	(r236846)
+++ head/sys/dev/ata/ata-all.c	Sun Jun 10 11:17:14 2012	(r236847)
@@ -1875,7 +1875,7 @@ ataaction(struct cam_sim *sim, union ccb
 		else
 			cpi->transport = XPORT_ATA;
 		cpi->transport_version = XPORT_VERSION_UNSPECIFIED;
-		cpi->protocol = PROTO_UNSPECIFIED;
+		cpi->protocol = PROTO_ATA;
 		cpi->protocol_version = PROTO_VERSION_UNSPECIFIED;
 		cpi->maxio = ch->dma.max_iosize ? ch->dma.max_iosize : DFLTPHYS;
 		if (device_get_devclass(device_get_parent(parent)) ==

Modified: head/sys/dev/mvs/mvs.c
==============================================================================
--- head/sys/dev/mvs/mvs.c	Sun Jun 10 10:40:22 2012	(r236846)
+++ head/sys/dev/mvs/mvs.c	Sun Jun 10 11:17:14 2012	(r236847)
@@ -2385,7 +2385,7 @@ mvsaction(struct cam_sim *sim, union ccb
 		cpi->unit_number = cam_sim_unit(sim);
 		cpi->transport = XPORT_SATA;
 		cpi->transport_version = XPORT_VERSION_UNSPECIFIED;
-		cpi->protocol = PROTO_UNSPECIFIED;
+		cpi->protocol = PROTO_ATA;
 		cpi->protocol_version = PROTO_VERSION_UNSPECIFIED;
 		cpi->maxio = MAXPHYS;
 		if ((ch->quirks & MVS_Q_SOC) == 0) {

Modified: head/sys/dev/siis/siis.c
==============================================================================
--- head/sys/dev/siis/siis.c	Sun Jun 10 10:40:22 2012	(r236846)
+++ head/sys/dev/siis/siis.c	Sun Jun 10 11:17:14 2012	(r236847)
@@ -1960,7 +1960,7 @@ siisaction(struct cam_sim *sim, union cc
 		cpi->unit_number = cam_sim_unit(sim);
 		cpi->transport = XPORT_SATA;
 		cpi->transport_version = XPORT_VERSION_UNSPECIFIED;
-		cpi->protocol = PROTO_UNSPECIFIED;
+		cpi->protocol = PROTO_ATA;
 		cpi->protocol_version = PROTO_VERSION_UNSPECIFIED;
 		cpi->maxio = MAXPHYS;
 		cpi->hba_vendor = pci_get_vendor(parent);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206101117.q5ABHEQX093676>