Date: Thu, 20 Dec 2007 23:43:34 +0100 From: Max Laier <max@love2party.net> To: freebsd-hackers@freebsd.org Subject: Re: Some diffs Message-ID: <200712202343.41507.max@love2party.net> In-Reply-To: <20071219.232511.-1548301831.imp@bsdimp.com> References: <20071219.232511.-1548301831.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart7936845.kka3y6JUg0
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Thursday 20 December 2007, M. Warner Losh wrote:
> Consider the following diffs. The first one does a tiny cleanup of
> strfile's include style (no real reason other than it bugged me when I
> added stdint.h).
>
> The second one cleans up a minor problem where ${CFLAGS} isn't used
> where it should be.
>
> The next three cleanup the compilation by not assuming sys/types.h is
> included or by also including <stdint.h>
>
> And the last, rather long, patch converts the .y in config to a form
> that more versions of yacc would grok.
>
> Comments?
sys/types.h (xor param.h) is supposed to be the first include (other than=20
cdefs.h) according to style. The rest seems fine from a quick glance.
=2D-=20
/"\ Best regards, | mlaier@freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier@EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
--nextPart7936845.kka3y6JUg0
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)
iD8DBQBHavAdXyyEoT62BG0RAsVeAJ9QSCXgJTpxlZBTI2VxXfUJe8nzGwCfYeY2
Zg+lIL9ba7h1PT0YmvHYjBg=
=xZAw
-----END PGP SIGNATURE-----
--nextPart7936845.kka3y6JUg0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712202343.41507.max>