Date: Fri, 22 Jun 2001 20:09:46 -0400 (EDT) From: Mike Heffner <mheffner@novacoxmail.com> To: "David O'Brien" <obrien@freebsd.org> Cc: freebsd-audit@freebsd.org, Mike Barcroft <mike@q9media.com>, phk@freebsd.org Subject: Re: whois(1) patch Message-ID: <XFMail.20010622200946.mheffner@novacoxmail.com> In-Reply-To: <20010622033201.B506@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format
--_=XFMail.1.4.7.FreeBSD:20010622200946:5666=_
Content-Type: text/plain; charset=us-ascii
On 22-Jun-2001 David O'Brien wrote:
| On Thu, May 31, 2001 at 02:30:21PM -0400, Mike Barcroft wrote:
|> > | It does the following:
|> > |
|> > | o Silence warnings and set WARNS=2
|> > | o Fix two memory leaks
|> > | o asprint -> strdup where appropriate
|> > | o calloc/strcpy/strcat -> aprintf
|> > | o Convert to ANSI C to avoid having to prototype main()
|
|
| You should separate your patches into functionality and style(9).
| I see DES just committed this patch as is, rather than break it into two
| parts as our practices says it should have been.
|
| You also changed puts() to printf(). Was there a reason for making that
| change?
Probably because style(9) mentions it:
Use printf(3), not fputs/puts/putchar/whatever; it's faster and usually
cleaner, not to mention avoiding stupid bugs.
Mike
--
Mike Heffner <mheffner@vt.edu>
Fredericksburg, VA <mikeh@FreeBSD.org>
http://filebox.vt.edu/users/mheffner
--_=XFMail.1.4.7.FreeBSD:20010622200946:5666=_
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE7M95KFokZQs3sv5kRAkzCAJ0aki4jqpHbqBxMurtLevRFjRqqOwCfUHCA
XdaCAeo8kyaFr0i0yhjmTu8=
=vCHc
-----END PGP SIGNATURE-----
--_=XFMail.1.4.7.FreeBSD:20010622200946:5666=_--
End of MIME message
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20010622200946.mheffner>