Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 01 Aug 2015 08:34:23 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Ed Schouten <ed@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r286147 - head/sys/compat/cloudabi
Message-ID:  <1488462.OiUCHEHk8E@ralph.baldwin.cx>
In-Reply-To: <201508010751.t717pmVi019785@repo.freebsd.org>
References:  <201508010751.t717pmVi019785@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, August 01, 2015 07:51:48 AM Ed Schouten wrote:
> Author: ed
> Date: Sat Aug  1 07:51:48 2015
> New Revision: 286147
> URL: https://svnweb.freebsd.org/changeset/base/286147
> 
> Log:
>   Allow CloudABI processes to create shared memory objects.
>   
>   Summary:
>   Use the newly created `kern_shm_open()` function to create objects with
>   just the rights that are actually needed.
>   
>   Reviewers: jhb, kib
>   
>   Subscribers: imp
>   
>   Differential Revision: https://reviews.freebsd.org/D3260

Can you please not use 'arc commit'?  For one, it doesn't follow the standard
FreeBSD commit template (and apparently it's hard to fix or we would have done
it by now), but it also isn't clear who actually reviews things.

What I do is keep the URL to the review open in another window and just copy
and paste the commit message and URL over to the stock template in my editor.
You can then set a proper 'Reviewed by' line that reflects who actually
reviewed the change as well.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1488462.OiUCHEHk8E>