Date: Thu, 28 Feb 2019 15:47:14 -0600 From: Kyle Evans <kevans@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: Bryan Drewery <bdrewery@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344666 - head/tools/build/mk Message-ID: <CACNAnaEFpXV4ooA8NY2-jJHKDKXHxc3SjcTPg6%2Bc0s7qk%2BNCQg@mail.gmail.com> In-Reply-To: <0EC04D65-721E-49F1-9755-7A8FDDE554DB@gmail.com> References: <201902282048.x1SKmILE082786@repo.freebsd.org> <0EC04D65-721E-49F1-9755-7A8FDDE554DB@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 28, 2019 at 3:44 PM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > > On Feb 28, 2019, at 12:48 PM, Bryan Drewery <bdrewery@FreeBSD.org> wrote: > > > > Author: bdrewery > > Date: Thu Feb 28 20:48:18 2019 > > New Revision: 344666 > > URL: https://svnweb.freebsd.org/changeset/base/344666 > > > > Log: > > bsd.nls.mk isn't optional. > > > > It is protected by MK_NLS. If it should really be optional then > > it needs to be documented as such in share/mk/bsd.README and > > .sinclude used where needed. > > > > This fixes a regression from r335011. > > > > PR: 232527 > > Submitted by: jarrod@downtools.com.au > > Reported by: ktullavik@gmail.com > > MFC after: 3 days > > Should bsd.{lib,prog}.mk instead be taught to ignore errors when including this file? > Thanks! > -Enji If we actually conditionally installed it, sure- it was only removed because of r335011, so it would go through an install/remove dance between installworld and delete-old on WITHOUT_NLS systems. If we're going to make it conditional on MK_NLS, it needs to actually be conditional on MK_NLS the proper way along with an s/.include/.sinclude/.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaEFpXV4ooA8NY2-jJHKDKXHxc3SjcTPg6%2Bc0s7qk%2BNCQg>