Date: Mon, 18 Dec 2000 10:17:34 -0800 (PST) From: Matt Dillon <dillon@earth.backplane.com> To: Assar Westerlund <assar@FreeBSD.ORG> Cc: Dag-Erling Smorgrav <des@ofug.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/libkern strlcat.c strlcpy.c src/sys/sys libkern.h src/sys/conf files Message-ID: <200012181817.eBIIHYk45510@earth.backplane.com> References: <200012180408.eBI48wg99879@freefall.freebsd.org> <xzpu282ypvp.fsf@flood.ping.uio.no> <5l66khluty.fsf@assaris.sics.se> <xzpitohzu34.fsf@flood.ping.uio.no> <xzpae9tztba.fsf@flood.ping.uio.no> <5lsnnlkcf7.fsf@assaris.sics.se> <xzp66khzsdn.fsf@flood.ping.uio.no> <5l4s01ka92.fsf@assaris.sics.se>
next in thread | previous in thread | raw e-mail | index | archive | help
:Dag-Erling Smorgrav <des@ofug.org> writes:
:> Ah, so you need to add one line and change another to make them comply
:> with the man page.
:
:More than that. I've not managed to write any strlcpy that is
:remarkable smaller than the one in libc in generated code and since I
:do not understand the point of squeezing these bytes from the code.
:Having the same code as in libc seems like more important to me. But
:since you find it important to squeeze down these functions to their
:minimal size, it's probably is better left in your hands writing them.
:
:/assar
Just use the libc version of strlcpy/strlcat, guys. strcpy/strcat is
not being used in any time-critical code and short of rewriting it in
assembly you aren't going to be able to make it much smaller then
what we already have in libc. GCC's optimizer does a pretty good job
on the libc version.
-Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012181817.eBIIHYk45510>