Date: Sat, 28 Feb 2015 07:01:54 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Garrett Cooper <ngie@FreeBSD.org> Cc: svn-src-head@freebsd.org, Jack F Vogel <jfv@FreeBSD.org>, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, erj@FreeBSD.org Subject: Re: svn commit: r279393 - head/sys/dev/ixgbe Message-ID: <3587EFB4-728C-475D-BC8B-3AFD98B5635B@gmail.com> In-Reply-To: <201502281457.t1SEvv4Y009907@svn.freebsd.org> References: <201502281457.t1SEvv4Y009907@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Feb 28, 2015, at 6:57, Garrett Cooper <ngie@FreeBSD.org> wrote: > Author: ngie > Date: Sat Feb 28 14:57:57 2015 > New Revision: 279393 > URL: https://svnweb.freebsd.org/changeset/base/279393 > > Log: > Pad RX copy alignment calculation to avoid illegal memory accesses > > The optimization made in r239940 is valid for struct mbuf's current structure > and size in FreeBSD, but hardcodes assumptions about sizes of struct mbuf, > which are unfortunately broken if additional data is added to the beginning of > struct mbuf > > X-MFC note (discussed with rwatson): > > This change requires the MPKTHSIZE definition, which is only available after > head@r277203 and will not be MFCed as it breaks mbuf(9) KPI. > > A direct commit to stable/10 and merges to other branches to add the necessary > definitions to work with the code as-is will be done to facilitate this MFC > > PR: 194314 > MFC after: 2 weeks > Approved/Reviewed by: erj, jfv > Sponsored by: EMC / Isilon Storage Division I forgot to note that the fix was submitted by erj in the PR. I’ll fix that in the MFC message. Thank you very much for the help Eric and Jack! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU8dhiAAoJEMZr5QU6S73eCAgIAID3DQA9r9I1dwAglhSXMoPf QNft5WQxlB5InWequxEFdsceRl1ylvFb7NiBbAZvR16oYmnSSupFyiSBya84Z+D8 ssYcsx4KABw92HcYvrQjV8oi0D16W3vKLI0oTE2gDPEbsT+sV6wRafXEYBvXydYi bRUVyeiTkBWU+KLxttXDrxkY8O33st6PdjWbiqG12IRRB7/mNfT5IYDtnRBHCB7T h77Xgks+qwHiy7IfnTGqedmJGD4unAUUTgCwBKQuv8GeybKmAoOaJLajPZbEXQ3T cpnKG/WpuLh4WPpy4aKg1xwHvg7mjV1znL7qJCArlAk6VCJXut7h1duh+UvOG4k= =0WL/ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3587EFB4-728C-475D-BC8B-3AFD98B5635B>