Date: Tue, 3 Nov 2009 21:06:19 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/kern subr_log.c subr_prf.c src/sys/sys msgbuf.h Message-ID: <200911032111.nA3LBqf5004846@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2009-11-03 21:06:19 UTC
FreeBSD src repository
Modified files:
sys/kern subr_log.c subr_prf.c
sys/sys msgbuf.h
Log:
SVN rev 198860 on 2009-11-03 21:06:19Z by ed
Make /dev/klog and kern.msgbuf* MPSAFE.
Normally msgbufp is locked using Giant. Switch it to use the
msgbuf_lock. Instead of changing the tsleep() calls to msleep(), just
convert it to condvar(9).
In my opinion the locking around msgbuf_peekbytes() still remains
questionable. It looks like locks are dropped while performing copies of
multiple blocks to userspace, which may cause the msgbuf to be reset in
the mean time. At least getting it underneath from Giant should make it
a little easier for us to figure out how to solve that.
Reminded by: rdivacky
Revision Changes Path
1.66 +41 -32 src/sys/kern/subr_log.c
1.139 +16 -5 src/sys/kern/subr_prf.c
1.29 +1 -0 src/sys/sys/msgbuf.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911032111.nA3LBqf5004846>