Date: Fri, 16 Mar 2007 22:10:21 -0700 From: "Kip Macy" <kip.macy@gmail.com> To: "Andre Oppermann" <andre@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp.h tcp_input.c tcp_output.c tcp_syncache.c tcp_var.h Message-ID: <b1fa29170703162210m6b29de6bu9b028c8b355b30cd@mail.gmail.com> In-Reply-To: <200703151559.l2FFxSG7088256@repoman.freebsd.org> References: <200703151559.l2FFxSG7088256@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I get a panic in tcp_syncache when I fire up xemacs over "ssh -Y".
-Kip
On 3/15/07, Andre Oppermann <andre@freebsd.org> wrote:
> andre 2007-03-15 15:59:28 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/netinet tcp.h tcp_input.c tcp_output.c
> tcp_syncache.c tcp_var.h
> Log:
> Consolidate insertion of TCP options into a segment from within tcp_output()
> and syncache_respond() into its own generic function tcp_addoptions().
>
> tcp_addoptions() is alignment agnostic and does optimal packing in all cases.
>
> In struct tcpopt rename to_requested_s_scale to just to_wscale.
>
> Add a comment with quote from RFC1323: "The Window field in a SYN (i.e.,
> a <SYN> or <SYN,ACK>) segment itself is never scaled."
>
> Reviewed by: silby, mohans, julian
> Sponsored by: TCP/IP Optimization Fundraise 2005
>
> Revision Changes Path
> 1.35 +5 -2 src/sys/netinet/tcp.h
> 1.317 +2 -2 src/sys/netinet/tcp_input.c
> 1.126 +199 -146 src/sys/netinet/tcp_output.c
> 1.105 +43 -75 src/sys/netinet/tcp_syncache.c
> 1.140 +14 -8 src/sys/netinet/tcp_var.h
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b1fa29170703162210m6b29de6bu9b028c8b355b30cd>