Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jan 2002 01:20:01 -0800 (PST)
From:      Jim Mock <mij@soupnazi.org>
To:        freebsd-doc@freebsd.org
Subject:   Re: docs/33913: GNATS webinterface isn't wrapping lines
Message-ID:  <200201160920.g0G9K1d33806@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/33913; it has been noted by GNATS.

From: Jim Mock <mij@soupnazi.org>
To: Ted Mittelstaedt <tedm@toybox.placo.com>
Cc: ru@FreeBSD.org, freebsd-doc@FreeBSD.org,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
Date: Wed, 16 Jan 2002 01:15:33 -0800

 On Wed, 16 Jan 2002 at 01:06:48 -0800, Ted Mittelstaedt wrote:
 > >-----Original Message-----
 > >From: Jim Mock [mailto:mij@soupnazi.org]
 > >Sent: Tuesday, January 15, 2002 11:56 PM
 > >To: Ted Mittelstaedt
 > >Cc: ru@FreeBSD.org; freebsd-doc@FreeBSD.org;
 > >freebsd-gnats-submit@FreeBSD.org
 > >Subject: Re: docs/33913: GNATS webinterface isn't wrapping lines
 > >
 > >>
 > >> Note the addition of the "wrap" directive.
 > >
 > >The wrap attribute is not valid in HTML 4.01.
 > >
 > 
 > It was not my intent to start a religious argument.  User input code
 > that doesen't massage the input is a coding error - what happens if
 > some joker decides to put in a javascript in a PR that does something
 > nasty?  Are we checking for that?
 
 You'd have to check dosendpr.cgi.
 
 > The wrap attribute was NEVER valid in any HTML spec.  It is and
 > remains a quick hack to get out of massaging user input.
 > 
 > Obviously the best way to solve this would be to further process the
 > user input on the webform to insert linebreaks in case someone uses a
 > browser that doesen't do what the code expects is "right"
 > 
 > But if nobody writes one then what's wrong with a quick hack?
 
 What's wrong with it is that when the web site is built, the code is
 validated, and if non-existant stuff is found, the build fails.  If we
 add the wrap attribute, the build will fail because it isn't valid.
 
 > The PR database already has a lot of these unwrapped entries with
 > lines that scroll off the side of the screen.  Which is more important
 > - making PR's readable or being "right"?
 
 That's what horizontal scroll is for :-)  Seriously though, patches are
 welcome to make things readable, but yes, it also must be "right" or
 there will be problems with the build.
 
 - jim
 
 -- 
 jim mock <mij@soupnazi.org>   http://soupnazi.org/ | jim@FreeBSD.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201160920.g0G9K1d33806>