Date: Wed, 7 Oct 2015 08:48:11 +0200 From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <dumbbell@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: s3erios@gmail.com, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288653 - in head/sys/dev/drm2: . i915 Message-ID: <5614C02B.6040504@FreeBSD.org> In-Reply-To: <20151007061453.GH2257@kib.kiev.ua> References: <201510040745.t947jbp7082807@repo.freebsd.org> <20151004094649.GG11284@kib.kiev.ua> <56142CCC.7000807@FreeBSD.org> <20151007061453.GH2257@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 07.10.2015 08:14, Konstantin Belousov wrote: > I believe there are subtle differences between our- and Linux- nowait > behaviour. I claim (but do not want to take liability of prove it with > references to Linux code) that our M_NOWAIT may fail transiently due to > pagedaemon not keeping up with load, while Linux top-half nowait alloc > only fails for real out-of-resources conditions. > > What I am trying to say, leave M_NOWAIT out of syscalls. Some time ago > M_NOWAIT also means that the caller is allowed to use reserves to satisfy > allocation, but this was fixed. Ok, I understand. Let's revert to use M_WAITOK then. During the DRM core update, I also used M_NOWAIT. Likewise for the i915 WIP. I will change some of them back to M_WAITOK after checking the context of the allocation (syscall or not). Thank you for the clarification on those flags! -- Jean-Sébastien Pédron [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWFMAxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTMdAgQANEBsBUr8NULutL992GnpuYb UM7jnuVhpr3Kg3LuQC9DkmOxYvub+QKEYQeMSSvX0Iv2XqoAxj18MzPW1PBpbmrB BoAnPmHNvm9tpxYWAY1QB04fx5bfxjpdRGhsPYwIktG32ll+lGp07yX57IRiG1Us ohWKf/SgUsaaQ6X3kOdGyhTVprAb+AI9xWi+nIK5Il9U567w5tZmnMT/j+dgy81c +OzPtBc/QEee79xw8kGSAhnfEb506KF7Pw+CVl9FMk8vYoxwwG8Z96ayTPpBnbP+ OZqYgSFbpY5QV7SwUY2wuRgvh9Kk/qF6Q8WjEdgj16nCDaTj3Hoev5LF81AWFihp SQnGGZyo+myrw31Y8QfMb1va1QYAnYO03lQnxjjV5bRU9uVW/UThFSGDbZzh2rOw Lb/wKPnzt3yhS4S8GalinVf9JPM/d/pcUrC2MPoHs/i8oQLx9uquVECKj9EyqiqH +vl4cUCMf9h0q4+SjFn+DKm3/K/adTrseI9w0Rt5Zh/aMAyTr6UkRw+AyPu0AouB jHYuTH03UiSQcBLbgRdYEdnnEvrukVoetpnnrXmC9RTvjkP04Z0vq1299mL49ejL aSbw79qfEiiOnGqo44pcRTdTsqRhBbZCXLivcGZAhJ4iW/VlfMiCgg/x9MiwwvWg SkNmsp4C3ssSut+dliTF =npGi -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5614C02B.6040504>