Date: Fri, 24 Apr 2015 11:23:08 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: freebsd-net@FreeBSD.org, Poul-Henning Kamp <phk@phk.freebsd.dk> Subject: Re: should m_copyback possibly throw data away? Message-ID: <20150424182308.GK37063@funkthat.com> In-Reply-To: <20150424181158.GJ37063@funkthat.com> References: <20150424181158.GJ37063@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John-Mark Gurney wrote this message on Fri, Apr 24, 2015 at 11:11 -0700:
> I would also be fine w/ documenting this behavior, though I'm sure
> it'd be surprising to many that you'd have to check to make sure your
> data was properly copied.
Should have reviewed the m_copyback function before sending this
email...
It gets worse.. If the m_get to extend it fails, there is no
notification that your data didn't get copyied into the mbuf.. and no
warning in the man page that this function is unsafe and may cause
data loss...
Comments?
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150424182308.GK37063>