Date: Fri, 22 Feb 2019 09:03:39 -0600 From: David Bright <david@bright-family.net> To: John Baldwin <jhb@FreeBSD.org> Cc: Warner Losh <imp@bsdimp.com>, Garrett Cooper <yaneurabeya@gmail.com>, Bruce Evans <brde@optusnet.com.au>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344389 - head/usr.sbin/newsyslog Message-ID: <E976D177-7BF9-43FB-8156-4D40BFAABE5A@FreeBSD.org> In-Reply-To: <c755a052-66f2-0f26-c0eb-7dd9bd74154e@FreeBSD.org> References: <201902202205.x1KM5iZX036319@repo.freebsd.org> <20190221121712.Y989@besplex.bde.org> <3CD59489-0595-4D09-B5C9-C3F25D23BB8D@gmail.com> <CANCZdfrXx04JMFO-sUrQ9h8x47GPGpNp5Qe_npV8atPgxdejqQ@mail.gmail.com> <c755a052-66f2-0f26-c0eb-7dd9bd74154e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[=E2=80=A6 other discussion omitted=E2=80=A6]=20 On Feb 21, 2019, at 12:22 PM, John Baldwin <jhb@FreeBSD.org> wrote: >=20 >=20 > I'm +1 on Bruce's point on this. I find it similar to the recent = spate of > adding pointless '__dead2' annotations to usage functions that = unconditionally > call exit() (and thus are already inferred as __dead2 by any compiler > written in this millenium) I=E2=80=99ve reverted (r344468) the two commits that contained the = memory leak fixes at issue.=20 Thanks for the feedback. --=20 David Bright dab@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E976D177-7BF9-43FB-8156-4D40BFAABE5A>