Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Dec 2001 11:49:22 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        scsi@FreeBSD.org
Subject:   aic7xxx patch
Message-ID:  <XFMail.011213114922.jhb@FreeBSD.org>

next in thread | raw e-mail | index | archive | help

gcc30 complains about using ++ on the same variable multiple times in a
statement since the value of the variable at each point is not defined.  This
is a simple patch to address this issue in hte aic7xxx driver:

Index: dev/aic7xxx/aic7xxx.c
===================================================================
RCS file: /usr/cvs/src/sys/dev/aic7xxx/aic7xxx.c,v
retrieving revision 1.79
diff -u -r1.79 aic7xxx.c
--- dev/aic7xxx/aic7xxx.c       17 Aug 2001 04:22:50 -0000      1.79
+++ dev/aic7xxx/aic7xxx.c       13 Dec 2001 19:41:32 -0000
@@ -1382,22 +1382,21 @@
               hscb->scsiid,
               hscb->lun,
               hscb->cdb_len);
-       i = 0;
        printf("Shared Data: %#02x %#02x %#02x %#02x\n",
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++]);
+              hscb->shared_data.cdb[0],
+              hscb->shared_data.cdb[1],
+              hscb->shared_data.cdb[2],
+              hscb->shared_data.cdb[3]);
        printf("             %#02x %#02x %#02x %#02x\n",
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++]);
+              hscb->shared_data.cdb[4],
+              hscb->shared_data.cdb[5],
+              hscb->shared_data.cdb[6],
+              hscb->shared_data.cdb[7]);
        printf("             %#02x %#02x %#02x %#02x\n",
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++],
-              hscb->shared_data.cdb[i++]);
+              hscb->shared_data.cdb[8],
+              hscb->shared_data.cdb[9],
+              hscb->shared_data.cdb[10],
+              hscb->shared_data.cdb[11]);
        printf("        dataptr:%#x datacnt:%#x sgptr:%#x tag:%#x\n",
                ahc_le32toh(hscb->dataptr),
                ahc_le32toh(hscb->datacnt),


Any objections?

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011213114922.jhb>