Date: Sat, 1 Aug 2015 16:02:03 -0500 From: Guy Helmer <guy.helmer@gmail.com> To: Ed Schouten <ed@nuxi.nl> Cc: Luiz Otavio O Souza <loos@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286142 - head/sys/net Message-ID: <EB54E04B-2312-495E-8D36-DD283582E256@gmail.com> In-Reply-To: <CABh_MKn5vfXB4Hv3mfAVgy7g98_U%2BcQ=XKyVTLdVJO3pp0-05Q@mail.gmail.com> References: <201507312143.t6VLhSBm046797@repo.freebsd.org> <CABh_MKn5vfXB4Hv3mfAVgy7g98_U%2BcQ=XKyVTLdVJO3pp0-05Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Aug 1, 2015, at 4:50 AM, Ed Schouten <ed@nuxi.nl> wrote:
>
> Hi Luiz,
>
> 2015-07-31 23:43 GMT+02:00 Luiz Otavio O Souza <loos@freebsd.org>:
>> - while (d->bd_hbuf_in_use)
>> - mtx_sleep(&d->bd_hbuf_in_use, &d->bd_lock,
>> - PRINET, "bd_hbuf", 0);
>
> Would it make sense to replace them by an assertion, instead of
> omitting them entirely?
>
> KASSERT(!d->bd_hbuf_in_use, ("..."));
I would appreciate the confidence that would provide.
Guy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EB54E04B-2312-495E-8D36-DD283582E256>