Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 29 Jun 2016 19:44:55 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 210709] freebsd/sys/dev/pcf/pcf_isa.c:112]: (style) Suspicious condition
Message-ID:  <bug-210709-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210709

            Bug ID: 210709
           Summary: freebsd/sys/dev/pcf/pcf_isa.c:112]: (style) Suspicious
                    condition
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

freebsd/sys/dev/pcf/pcf_isa.c:112]: (style) Suspicious condition (assignment +
comparison); Clarify expression with parentheses.

Source code is

    if ((error = resource_int_value(PCF_NAME, 0, "port", &port) != 0))
        return (error);

Maybe better code

    if ((error = resource_int_value(PCF_NAME, 0, "port", &port)) != 0)
        return error;

-- 
You are receiving this mail because:
You are the assignee for the bug.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210709-8>