Date: Tue, 2 Nov 2004 15:49:27 -0500 From: John Baldwin <jhb@FreeBSD.org> To: David Xu <davidxu@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_private.h thr_sig.c Message-ID: <200411021549.27511.jhb@FreeBSD.org> In-Reply-To: <4186C114.1000004@freebsd.org> References: <200411011049.iA1AnY8m012136@repoman.freebsd.org> <4186960C.6090805@elischer.org> <4186C114.1000004@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 01 November 2004 06:04 pm, David Xu wrote: > Not every important, I think I have another very important history > bug in hand, did you get my "fix famous libpthread conditional > variable race condition" mail ? :-) Oooo, can I test it please? We are still having problems with mono on HEAD here at work. I tried merging the changes in uthread_cond.c 1.32 to libpthread but that seemed to make it worse. The problems seem to be that a signal handler is being run when the SYNCQ sflag is set (but the thread is not on a cv or a mutex queue), and the handler calls sem_post() which is supposed to be signal safe. sem_post() tries to lock a mutex and then bombs with the assertion failure. > David Xu > > Julian Elischer wrote: > > shuold there be an MFC date? > > > > David Xu wrote: > >> davidxu 2004-11-01 10:49:34 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> lib/libpthread/thread thr_private.h thr_sig.c Log: > >> Save cancelflags in signal frame, this fixes a problem that > >> a thread in pthread_cond_wait handled a signal can no longer > >> be canceled. > >> > >> Reviewed by: deischen > >> > >> Revision Changes Path > >> 1.120 +1 -0 src/lib/libpthread/thread/thr_private.h > >> 1.82 +2 -0 src/lib/libpthread/thread/thr_sig.c -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411021549.27511.jhb>