Date: Mon, 6 Jun 2005 20:37:09 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-raid.c Message-ID: <8F5450B3-BEB2-4FAC-A8C4-E64D626EA1C6@FreeBSD.org> In-Reply-To: <42A490F2.4010705@root.org> References: <20050606154917.7AEE716A42B@hub.freebsd.org> <42A490F2.4010705@root.org>
index | next in thread | previous in thread | raw e-mail
On 06/06/2005, at 20:07, Nate Lawson wrote:
> Søren Schmidt wrote:
>
>> sos 2005-06-06 15:49:09 UTC
>> FreeBSD src repository
>> Modified files:
>> sys/dev/ata ata-raid.c Log:
>> Apply the usual woodoo for 64bitness.
>> Revision Changes Path
>> 1.97 +2 -2 src/sys/dev/ata/ata-raid.c
>> Index: src/sys/dev/ata/ata-raid.c
>> diff -u src/sys/dev/ata/ata-raid.c:1.96 src/sys/dev/ata/ata-raid.c:
>> 1.97
>> --- src/sys/dev/ata/ata-raid.c:1.96 Mon Jun 6 13:35:23 2005
>> +++ src/sys/dev/ata/ata-raid.c Mon Jun 6 15:49:09 2005
>> @@ -3822,8 +3822,8 @@
>> printf("revision %.4s\n", meta->revision);
>> printf("dummy_1 0x%08x\n", meta->dummy_1);
>> printf("magic_0 0x%08x\n", meta->magic_0);
>> - printf("magic_1 0x%016llx\n", meta->magic_1);
>> - printf("magic_2 0x%016llx\n", meta->magic_2);
>> + printf("magic_1 0x%016llx\n",(unsigned long long)
>> meta->magic_1);
>> + printf("magic_2 0x%016llx\n",(unsigned long long)
>> meta->magic_2);
>> printf("flags 0x%02x\n", meta->flags);
>> printf("array_width %d\n", meta->array_width);
>> printf("total_disks %d\n", meta->total_disks);
>>
>
> I think %jx is preferred to a cast.
I think I prefer the style of the rest of ATA.
- Søren
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8F5450B3-BEB2-4FAC-A8C4-E64D626EA1C6>