Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Oct 2015 21:45:50 -0400
From:      Alexander Kabaev <kabaev@gmail.com>
To:        Ed Maste <emaste@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r289728 - head
Message-ID:  <20151021214550.70b25f13@kan>
In-Reply-To: <201510220132.t9M1WBW9087666@repo.freebsd.org>
References:  <201510220132.t9M1WBW9087666@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/YqHnDqj/mtPjNAt8f1KdOMh
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Thu, 22 Oct 2015 01:32:11 +0000 (UTC)
Ed Maste <emaste@FreeBSD.org> wrote:

> Author: emaste
> Date: Thu Oct 22 01:32:11 2015
> New Revision: 289728
> URL: https://svnweb.freebsd.org/changeset/base/289728
>=20
> Log:
>   Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>  =20
>   NO_CLEAN has been the correct spelling for over a decade.
>=20
> Modified:
>   head/Makefile.inc1
>=20
> Modified: head/Makefile.inc1
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/Makefile.inc1	Thu Oct 22 01:04:31 2015
> (r289727) +++ head/Makefile.inc1	Thu Oct 22 01:32:11
> 2015	(r289728) @@ -128,6 +128,7 @@ SUBDIR+=3Detc
>  .endif	# !empty(SUBDIR_OVERRIDE)
> =20
>  .if defined(NOCLEAN)
> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>  NO_CLEAN=3D	${NOCLEAN}
>  .endif
>  .if defined(NO_CLEANDIR)


For some definition of 'correct'. It definitely is not for those who
have -DNOCLEAN wired into their finger memory and above mentioned
decade did not help with that any.

I think some of the common spellings were left as is in great NO_<foo>
revolution for a reason and I see no reason why the sudden itch to
change that.

--=20
Alexander Kabaev

--Sig_/YqHnDqj/mtPjNAt8f1KdOMh
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJWKD/OXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw
NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5+zV4P/3NGaQx+0Jm9HMD3PQvWOpiv
z0/T97bjxh4tGZut8QWFWMFRGaWaDZur9cKJbFdQAVr9LWRGgTcdH3uh3FtYbc5p
ww2kPtcfU3Ph5jp6m5/akrX+25tS9fE2XcgBt7vYPIxFCOGRTslr9tlbOYWFwx7+
fG68CPPxCplKqFOLCvTbcMUgViDNXeqCxaSYRy2mUxxdLNn0YqrANCAEsBXmlVsI
KBtLcgGARXeV0MhBaQrxn2VUjVqmGSjDISGASQ/UbtG3t1Vc95xmVNYLyQPiLWCX
PkysoPMx4NhlUpOifWFEiOrKXjF72zzZAxjpyQX3TSxeSMemDJzWBPkIHxfluVGW
GekwbHee255cUGqC5lMEXE3UWVmzIJt7rAxGuDsXkZPlQmAAoWuqk0wPP4SYrPhN
ZS83ASCrC9xyYnci47LcOKeg5bpBiR16znQH886EAl5WZsE+PVYwuPdamIO1a9WD
ueUF8OVv7jJB9m7JSISmiwibH8D4brLHDqc9zyRkuDzx4+77AotH99kPSbUnIJxU
oE/xKf61eHHUy8ISptETc+PR+k2JZOxXcv4gtk/vKA+gCvIxpeVL+cz2LboNkaeW
iQWt0xFc68eG2RhmO/u+X5ILxBnD/68CC0l+Evop2mVt1NEJNVziMIFJkZG4+HC5
G9l9M4/qve0/Cb7hIbB+
=d68+
-----END PGP SIGNATURE-----

--Sig_/YqHnDqj/mtPjNAt8f1KdOMh--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151021214550.70b25f13>