Date: Thu, 21 Jun 2018 16:51:43 -0500 From: Kyle Evans <kevans@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335509 - head/sys/kern Message-ID: <CACNAnaFDTXz%2BPOqu7FSPJdZ7Q%2BHcuCrO2Zsq5ZBqGxCjThE7Vg@mail.gmail.com> In-Reply-To: <201806212150.w5LLo0d3072797@repo.freebsd.org> References: <201806212150.w5LLo0d3072797@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 21, 2018 at 4:50 PM, Kyle Evans <kevans@freebsd.org> wrote: > Author: kevans > Date: Thu Jun 21 21:50:00 2018 > New Revision: 335509 > URL: https://svnweb.freebsd.org/changeset/base/335509 > > Log: > subr_hints: Fix acpi unit hinting (at the very least) > > The refactoring in r335479 overlooked the fact that the dynamic kenv can > also be switched to if hintmode == 0. This is problematic because the > checkmethod bits are only ever ran once, but it worked previously because > the use_kenv was a global state and the first lookup would enable it if > occurring after the dynamic environment has been setup. > > Extending our local definition of use_kenv to include all non-STATIC > hintmodes as long as the dynamic_kenv is setup fixes this. We still have > potential issues if the dynamic kenv comes up while we're doing an anchored > search through the environment, but this is not much of a concern right now > because: > > 1.) The dynamic environment comes up super early in boot, just after kmem > > 2.) This is going to get rewritten to provide a safer mechanism for the > anchored searches, ensuring that we continue using the same environment > chain (dynamic env or static fallback) for all anchored search invocations > > Reported by: mmamcy > X-MFC-With: r335479 > Reported by: mmacy*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFDTXz%2BPOqu7FSPJdZ7Q%2BHcuCrO2Zsq5ZBqGxCjThE7Vg>