Date: Wed, 15 Jan 2014 16:50:22 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, John Marino <marino@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: svn commit: r339777 - head/lang/modula3 Message-ID: <20140115155022.GI77567@ithaqua.etoilebsd.net> In-Reply-To: <20140115154348.GA54731@mouf.net> References: <201401151341.s0FDfQ1M053094@svn.freebsd.org> <998760DE607B43BBDEA3C8AE@ogg.in.absolight.net> <20140115151820.GH77567@ithaqua.etoilebsd.net> <20140115154348.GA54731@mouf.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--16qp2B0xu0fRvRD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 15, 2014 at 03:43:49PM +0000, Steve Wills wrote: > On Wed, Jan 15, 2014 at 04:18:20PM +0100, Baptiste Daroussin wrote: > > On Wed, Jan 15, 2014 at 03:17:08PM +0100, Mathieu Arnold wrote: > > > +--On 15 janvier 2014 13:41:26 +0000 John Marino <marino@FreeBSD.org>= wrote: > > > | lang/modula3: Not for FreeBSD 8.x > > > | =20 > > > | +. if !exists(/usr/include/xlocale/_ctype.h) > > > | +IGNORE=3D the bootstrap compiler only runs on FreeBSD 9.0 or later > > > | +. endif > > > | . endif > > >=20 > > > That should be .if ${OSVERSION} < 9000000 or something. > > >=20 > > > --=20 > > > Mathieu Arnold > >=20 > > It is better to test for the existence of a file as if some are creating > > custom images they without that file it will match anyway. > >=20 > > OSVERSION is a legacy from pointyhat/tinderbox time, now pointyhat is g= one and > > tinderbox knows how to check in the real destination target and not in = the host, > > lots of those OSVERSION can just die. >=20 > How would this work in the case of a change to a file that already exists= as > opposed to a file existing? Then testing the content of the file is the only safe way (that is what I d= o in compiler.mk) regards, Bapt --16qp2B0xu0fRvRD7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLWrj4ACgkQ8kTtMUmk6Ex0+wCfQVp6Ee/HZmPrTm8/bK7GTAyQ vkIAoKxBJZk+FOj18QHzW9gqVPwiDuiJ =gLzb -----END PGP SIGNATURE----- --16qp2B0xu0fRvRD7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140115155022.GI77567>