Date: Sun, 08 Jun 2008 22:01:27 -0700 From: Tim Kientzle <kientzle@freebsd.org> To: Jeremie Le Hen <jeremie@le-hen.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile Message-ID: <484CB927.3050101@freebsd.org> In-Reply-To: <20080608075256.GA35560@obiwan.tataz.chchile.org> References: <200805261721.m4QHLCF4070787@repoman.freebsd.org> <20080608075256.GA35560@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This case is a little unusual: by default, I want to
install both 'cpio' programs and symlink the common name
to one of them.
How about this:
WITH_GCPIO (default) - installs gcpio, symlinks 'cpio' unless
WITH_BSDCPIO defined
WITHOUT_GCPIO - does not install gcpio at all
WITH_BSDCPIO (default) - installs bsdcpio, symlinks 'cpio'
WITHOUT_BSDCPIO - does not install bsdcpio at all
This way, WITHOUT_BSDCPIO gives you the old behavior,
WITHOUT_GCPIO gives you the proposed new behavior;
the default gives you the transitional behavior.
Tim Kientzle
Jeremie Le Hen wrote:
> Hi Tim,
>
> First of all, thanks for this work. It greatly contributes to the
> cleanness of the overall source tree :-).
>
> On Mon, May 26, 2008 at 05:21:12PM +0000, Tim Kientzle wrote:
>
>>kientzle 2008-05-26 17:21:12 UTC
>>
>> FreeBSD src repository
>>
>> Modified files:
>> gnu/usr.bin/cpio Makefile
>> Log:
>> Install GNU cpio as 'gcpio', symlink to 'cpio' unless WITH_BSDCPIO is
>> defined.
>
>
> There have been much work to glean all build flags over the source tree
> into a single place, namely src/share/bsd.own.mk. See [1]. I think it
> would be better to stick to this scheme and not spread those knobs back
> in the tree.
>
> [1] http://www.freebsd.org/cgi/cvsweb.cgi/src/share/mk/bsd.own.mk#rev1.44
>
> Thanks.
> Regards,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?484CB927.3050101>