Date: Sat, 18 Apr 2009 08:51:06 +0100 From: Iain Hibbert <plunky@rya-online.net> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: freebsd-bluetooth@freebsd.org Subject: RE: libhci update Message-ID: <E1Lv5La-00058x-HH@smtpbarns01>
index | next in thread | raw e-mail
> thanks for the feedback. i'm attaching revisited patch. please take a > look and let me know if this is something you happy with. (pls ignore typos & bad formatting, am on mobile device :) Bt_devrecv() should probably take void * for buffer? Also manpage suggests it will only receive hci events. Do you think its worth doing some validation of received data? (eg return EIO for truncated reads?) Bt_devinquiry() should probably restore the filter after use? Also needs to ensure hci event packets are enabled? Bt_devreq() needs to set/restore a filter too In bt_devreq structure event should be uint8_t? Also clen and rlen should be size_t Do you think its worth to cook dev_class into a normalised host numeric value rather than 3 bytes ? Probably need to specifically mention that the inquiry response to be released using free() in manpage? Something i thought about on the train yesterday but can't visualise on the small screen. For device inquiry did you consider using a callback method (as per devenum) in stead of returning the structure array? At least i recall my nokia would show the list building (but perhaps that was when it got the names) and this windows mobile device does show the raw list in progress (though stupidly just displays a list of 'unknown device' until it gets the names :) Regards, iainhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1Lv5La-00058x-HH>