Date: Mon, 5 Apr 2004 21:16:53 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Robert Watson <rwatson@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_gif.c Message-ID: <20040405181653.GA1212@ip.net.ua> In-Reply-To: <Pine.NEB.3.96L.1040331090544.4625B-100000@fledge.watson.org> References: <20040331072756.GA14337@ip.net.ua> <Pine.NEB.3.96L.1040331090544.4625B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Mar 31, 2004 at 09:06:56AM -0500, Robert Watson wrote: > > On Wed, 31 Mar 2004, Ruslan Ermilov wrote: > > > > > Implemented this in the attached patch. Note when testing: setting > > > > net.link.gif.max_nesting too high (>20 on my system) and triggering > > > > the recursion causes the kernel stack exhaustion. > > > > > > Why not just do what OpenBSD does and do actual loop detection? This > > > gets rid of the nesting count hack which isn't really what you want to > > > measure anyway. > > > > > > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/if_gif.c.diff?r1=1.18&r2=1.19 > > > > > Good idea. I will implement it and repost the updated patch here. > > While you're at it, we also need loop detection in if_gre. Make sure to > check the IP- and IPv6-layer pieces of these as well. > Um, what do you mean, should I _check_ by running, or what? Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAcaKVUkv4P6juNwoRAl2EAJkBihQsgZL9doQumrMW1QZqyGBvtQCff+0C hyYsktlx/OMtyqBvvk7bzTg= =yr9C -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040405181653.GA1212>