Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Oct 2023 20:19:46 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 538f8bdc8bc4 - main - otus: splnet isn't a thing, remove place holders
Message-ID:  <202310272019.39RKJkqV061523@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=538f8bdc8bc4ebb868ab0ae12537815d27e310eb

commit 538f8bdc8bc4ebb868ab0ae12537815d27e310eb
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2023-10-27 20:03:51 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-10-27 20:03:51 +0000

    otus: splnet isn't a thing, remove place holders
    
    Even though it's if 0'd code, remove splnet/splx. This code can't
    possibly run on FreeBSD, but having it here as a marker isn't especially
    helpful. It causes a false positive on grepping otherwise.
    
    Sponsored by:           Netflix
---
 sys/dev/otus/if_otus.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/dev/otus/if_otus.c b/sys/dev/otus/if_otus.c
index aee765ff4ac8..c27b982d2d6e 100644
--- a/sys/dev/otus/if_otus.c
+++ b/sys/dev/otus/if_otus.c
@@ -3059,17 +3059,14 @@ otus_calibrate_to(void *arg, int pending)
 	device_printf(sc->sc_dev, "%s: called\n", __func__);
 	struct ieee80211com *ic = &sc->sc_ic;
 	struct ieee80211_node *ni;
-	int s;
 
 	if (usbd_is_dying(sc->sc_udev))
 		return;
 
 	usbd_ref_incr(sc->sc_udev);
 
-	s = splnet();
 	ni = ic->ic_bss;
 	ieee80211_amrr_choose(&sc->amrr, ni, &((struct otus_node *)ni)->amn);
-	splx(s);
 
 	if (!usbd_is_dying(sc->sc_udev))
 		timeout_add_sec(&sc->calib_to, 1);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202310272019.39RKJkqV061523>