Date: Fri, 19 Nov 2021 10:05:28 -0500 From: Alexander Motin <mavbsd@gmail.com> To: Warner Losh <imp@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9cb485d18f01 - main - geom: Remove g_class.config Message-ID: <708f1f87-0082-5259-24df-cf23b87b628f@gmail.com> In-Reply-To: <202111190620.1AJ6KS08078314@gitrepo.freebsd.org> References: <202111190620.1AJ6KS08078314@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I have no objections, but I'd leave padding there to not break KBI for out of tree GEOM classes. On 19.11.2021 01:20, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9cb485d18f01900800efe4ec3cfcfadd335da858 > > commit 9cb485d18f01900800efe4ec3cfcfadd335da858 > Author: Wuyang Chung <wy-chung@outlook.com> > AuthorDate: 2021-10-16 01:43:54 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2021-11-19 06:17:07 +0000 > > geom: Remove g_class.config > > g_class.config is write only, remove it. > --- > sys/geom/geom.h | 1 - > sys/geom/geom_subr.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/sys/geom/geom.h b/sys/geom/geom.h > index 1aba1f46d6d5..0d6d74d0b51c 100644 > --- a/sys/geom/geom.h > +++ b/sys/geom/geom.h > @@ -96,7 +96,6 @@ struct g_class { > u_int version; > u_int spare0; > g_taste_t *taste; > - g_config_t *config; > g_ctl_req_t *ctlreq; > g_init_t *init; > g_fini_t *fini; > diff --git a/sys/geom/geom_subr.c b/sys/geom/geom_subr.c > index 2f7ea7754f7b..abaae5ccf57f 100644 > --- a/sys/geom/geom_subr.c > +++ b/sys/geom/geom_subr.c > @@ -222,7 +222,6 @@ retry: > > /* Bar new entries */ > mp->taste = NULL; > - mp->config = NULL; > > LIST_FOREACH(gp, &mp->geom, geom) { > error = mp->destroy_geom(NULL, mp, gp); > -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?708f1f87-0082-5259-24df-cf23b87b628f>