Date: Wed, 10 Feb 2021 16:31:22 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Joseph Mingrone <jrm@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r564803 - in head/sysutils: . rmlint rmlint/files Message-ID: <20210210163122.GA26910@FreeBSD.org> In-Reply-To: <868s7wlyd8.fsf@phe.ftfl.ca> References: <202102091926.119JQQL8050604@repo.freebsd.org> <20210210023501.GA65146@FreeBSD.org> <868s7wlyd8.fsf@phe.ftfl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 10, 2021 at 11:46:11AM -0400, Joseph Mingrone wrote: > On Wed, 2021-02-10 at 02:35, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > > On Tue, Feb 09, 2021 at 07:26:26PM +0000, Joseph Mingrone wrote: > >> New Revision: 564803 > >> URL: https://svnweb.freebsd.org/changeset/ports/564803 > > >> Log: > >> New port, sysutils/rmlint: Remove duplicates from your filesystem > > > Hi Joseph, > > > I'm afraid this was not sufficiently reviewed, there are number of > > issues with this port, I'll comment on the more serious ones. > > All should be fixed in r564864. > > There was a long gap between when I first looked at this submission and > when I committed. I thought that I had reviewed it more closely, but > apparently not. When it passed build and run tests, I committed too > quickly. Understood; thank you! ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210210163122.GA26910>