Date: Sat, 11 Feb 2006 19:19:29 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/lib/libmemstat memstat_uma.c Message-ID: <200602111919.k1BJJTEm085929@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2006-02-11 19:19:29 UTC
FreeBSD src repository
Modified files:
lib/libmemstat memstat_uma.c
Log:
The uma_zone data structure defines the size of its uz_cpu[] array as 1,
but then sizes the containing data structure at run-time to make room
for per-cpu cache data. Modify libmemstat to separately allocate a
buffer to hold per-cpu cache data, sized based on the run-time mp_maxid
variable when using libkvm to access UMA data. This avoids reading
invalid cache data from beyond the end of the uma_zone data structure
on the stack, which can result in invalid statistics and/or reads from
invalid kernel addresses.
Foot target practice by: ps
MFC after: 3 days
Revision Changes Path
1.16 +24 -2 src/lib/libmemstat/memstat_uma.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602111919.k1BJJTEm085929>