Date: Sat, 20 Jan 2001 21:10:52 -0700 From: Wes Peters <wes@softweyr.com> To: Dima Dorfman <dima@unixfreak.org> Cc: Ben Smithurst <csxbcs@comp.leeds.ac.uk>, Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, freebsd-net@FreeBSD.ORG Subject: Re: manual page review: connect(2) EAGAIN error Message-ID: <3A6A614C.3004DD43@softweyr.com> References: <20010120234740.E74B53E02@bazooka.unixfreak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dima Dorfman wrote:
>
> > oops, looks like you already answered that (EADDRNOTAVAIL) in your last
> > message. sorry. If you fix the code to return EADDRNOTAVAIL then the PR
> > can be closed as it will no longer apply.
>
> I sent a patch to fix this in a response to this thread, but it seems
> noone noticed. You can find the e-mail here:
If I don't hear any objections, I'll commit this (and fix the man page).
For your review simplicity, the patch is:
Index: in_pcb.c
===================================================================
RCS file: /st/src/FreeBSD/src/sys/netinet/in_pcb.c,v
retrieving revision 1.71
diff -u -r1.71 in_pcb.c
--- in_pcb.c 2000/12/27 03:02:29 1.71
+++ in_pcb.c 2001/01/20 00:31:27
@@ -313,7 +313,7 @@
* occurred above.
*/
inp->inp_laddr.s_addr = INADDR_ANY;
- return (EAGAIN);
+ return (EADDRNOTAVAIL);
}
--*lastport;
if (*lastport > first || *lastport < last)
@@ -334,7 +334,7 @@
* occurred above.
*/
inp->inp_laddr.s_addr = INADDR_ANY;
- return (EAGAIN);
+ return (EADDRNOTAVAIL);
}
++*lastport;
if (*lastport < first || *lastport > last)
--
"Where am I, and what am I doing in this handbasket?"
Wes Peters Softweyr LLC
wes@softweyr.com http://softweyr.com/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A6A614C.3004DD43>