Date: Mon, 11 Oct 1999 11:48:22 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Peter Wemm <peter@netplex.com.au>, "Daniel C. Sobral" <dcs@newsguy.com>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/vm vm_swap.c Message-ID: <19432.939635302@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 11 Oct 1999 00:09:58 PDT." <199910110709.AAA20043@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199910110709.AAA20043@apollo.backplane.com>, Matthew Dillon writes: >:> >:> We're not removing the device interface. It provides a reasonable >:> abstraction and a nice demark between swap_pager.c and vm_swap.c, >:> as well as potential flexibility that could be useful in the future >:> Removing it will not save time or much in the way of code space. >: >:The swap *device* is non-functional and doesn't *do* anything except >:provide a subroutine call in a very roundabout way. I think it would be >:far better to avoid an indirection via the VOP_* system for no useful gain >:and do something like the aooended patch (which works perfectly here BTW, >:even under heavy swap load on multiple disks). Further (micro) >:optimizations are possible, for example pbgetvp() is used to get a p-buffer >:that's associated with swapdev_vp and the device. The device isn't used >:and presently vn_todev(vp) ends up returning NODEV. swapdev_vp is kinda >:orphaned with this change but still works ok. p-buffers are created being Peter, I have reviewed and tested your patch and it works fine. > Gentlemen. You might as well stop. I've said it before and I > will say it again: Nobody is screwing around with the swap > subsytem. I think we can safely say that this is not "screwing around with the swap subsytem", so obviously your possive position doesn't apply to Peters patch. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19432.939635302>