Date: Mon, 30 Mar 2015 00:21:45 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: Hans Petter Selasky <hps@selasky.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Fabien Thomas <fabient@freebsd.org> Subject: Re: svn commit: r280759 - head/sys/netinet Message-ID: <20150329212145.GC64665@FreeBSD.org> In-Reply-To: <CAJ-VmomQzEXV4KtokK7jBgqCHEwExvYxhHJBar1uY2=yB1BjAg@mail.gmail.com> References: <201503271326.t2RDQxd3056112@svn.freebsd.org> <20150328083443.GV64665@FreeBSD.org> <20150328191629.GY64665@FreeBSD.org> <5517B433.5010508@selasky.org> <CAJ-VmonU15_nEGVQNwR52deDf1TbPUz0oAMr%2B3zwNqU_9%2Bo1fw@mail.gmail.com> <20150329210757.GA64665@FreeBSD.org> <CAJ-VmomQzEXV4KtokK7jBgqCHEwExvYxhHJBar1uY2=yB1BjAg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 29, 2015 at 02:15:43PM -0700, Adrian Chadd wrote: A> > To illustrate the probability of 1 instruction race, I would suggest to A> > look at PCPU_ADD() implementation for all arches except amd64/i386 and A> > find out that it is prone to this race. Hitting the race in PCPU_ADD() A> > will usually lead to mangling vm_meter statistics. Did we ever observe A> > this in practice? No. A> A> I dunno. Has anyone actually looked at that? :) A> A> On a busy system you may find those small race windows exist enough to A> be annoying. Case in point - the recent callout code race. The race A> between "read" "modify" "write" was tiny, but enough to break things. The difference is that in callout it lead to an endless loop, and in discussed case it leads to IP ID reuse, which already is happening all the time. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150329212145.GC64665>