Date: Fri, 8 Jun 2018 10:08:25 -0400 From: Ed Maste <emaste@freebsd.org> To: Kirk McKusick <mckusick@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334814 - head/sbin/dump Message-ID: <CAPyFy2DxmjVw57vu9Cbn7X1qfgR58UtTzvMk2rzEHxfhBHm79g@mail.gmail.com> In-Reply-To: <201806072049.w57Kn1Mk057119@repo.freebsd.org> References: <201806072049.w57Kn1Mk057119@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7 June 2018 at 16:49, Kirk McKusick <mckusick@freebsd.org> wrote: > Author: mckusick > Date: Thu Jun 7 20:49:01 2018 > New Revision: 334814 > URL: https://svnweb.freebsd.org/changeset/base/334814 > > Log: > Ensure proper initialization of superblock. > ... > --- head/sbin/dump/main.c Thu Jun 7 19:57:55 2018 (r334813) > +++ head/sbin/dump/main.c Thu Jun 7 20:49:01 2018 (r334814) > @@ -433,6 +433,7 @@ main(int argc, char *argv[]) > msgtail("to %s\n", tape); > > sync(); > + sblock = NULL; > if ((ret = sbget(diskfd, &sblock, -1)) != 0) { sblock is initialized to NULL at the beginning of ffs_sbget, so I'm not really sure what's happening here.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DxmjVw57vu9Cbn7X1qfgR58UtTzvMk2rzEHxfhBHm79g>