Date: Sun, 25 Sep 2011 18:52:15 -0700 From: YongHyeon PYUN <pyunyh@gmail.com> To: Justin Hibbits <chmeeedalf@gmail.com> Cc: freebsd-wireless@freebsd.org, FreeBSD PowerPC ML <freebsd-ppc@freebsd.org> Subject: Re: CFT: macio attachment for if_wi Message-ID: <20110926015215.GB1702@michelle.cdnetworks.com> In-Reply-To: <54FFB452-534A-46C6-950B-880EB36F61C1@gmail.com> References: <54FFB452-534A-46C6-950B-880EB36F61C1@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 25, 2011 at 08:54:41AM -0400, Justin Hibbits wrote: > Attached is a patch adding the macio attachment for the if_wi driver, > to support the airport card in PowerPC macs. To do this I needed to > modify the wi_read_bap and wi_write_bap functions to use the bus space > stream functions instead of regular functions, like NetBSD and OpenBSD > do. I currently get a 'no carrier' status from ifconfig, so I can't > fully test connections, only the attachment. Testing wanted and > needed to make sure I didn't break anything. > It seems the WI_DATA0/WI_DATA1 registers provide access to data with FIFO style. This indicates driver have to read raw data and subsequent access would have to use htoleXX() macro to compare it with the raw data instead of converting it from little-endian to host byte order. So your patch looks like the first step that goes to right direction. As Adrian said, there could be multiple places that used wrong data from endianess view. BTW, you may have to implement suspend/resume method to properly stop driver before entering into suspend. > - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110926015215.GB1702>