Date: Sat, 18 Jan 2014 00:30:10 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Marcel Moolenaar <marcel@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r260844 - head/gnu/lib/libgcc Message-ID: <DF5F8D1C-A801-412A-AF4B-A6D4762F1F88@FreeBSD.org> In-Reply-To: <201401180409.s0I49eHu054407@svn.freebsd.org> References: <201401180409.s0I49eHu054407@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Marcel, Nice find ... Il giorno 17/gen/2014, alle ore 23:09, Marcel Moolenaar = <marcel@FreeBSD.org> ha scritto: > Author: marcel > Date: Sat Jan 18 04:09:39 2014 > New Revision: 260844 > URL: http://svnweb.freebsd.org/changeset/base/260844 >=20 > Log: > For ia64, add _bswapsi2 & _bswapdi2. The audio/flac port uses the > bswap32 builtin and the compiler emits a call to the libgcc function > rather than generating inline code. >=20 > Modified: > head/gnu/lib/libgcc/Makefile >=20 > Modified: head/gnu/lib/libgcc/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/gnu/lib/libgcc/Makefile Sat Jan 18 04:06:00 2014 = (r260843) > +++ head/gnu/lib/libgcc/Makefile Sat Jan 18 04:09:39 2014 = (r260844) > @@ -145,6 +145,7 @@ LIB1ASMFUNCS =3D __divxf3 __divdf3 __divsf > __divsi3 __modsi3 __udivsi3 __umodsi3 __save_stack_nonlocal \ > __nonlocal_goto __restore_stack_nonlocal __trampoline \ > _fixtfdi _fixunstfdi _floatditf > +LIB2FUNCS +=3D _bswapsi2 _bswapdi2 > LIB2ADDEH =3D unwind-ia64.c unwind-sjlj.c unwind-c.c > .endif >=20 I think this was an overlook on my part. This change: = http://svnweb.freebsd.org/base/head/contrib/gcc/mklibgcc.in?r1=3D169690&r2= =3D258428 would suggest the change is not only for ia64, and It should apply for = stable-10 but not for -9. where I detected the issue and was looking for a solution before merging = it further. Thank you for finding it and feel free to do it general and MFC if you = like ;-). Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DF5F8D1C-A801-412A-AF4B-A6D4762F1F88>