Date: Fri, 22 Mar 2002 17:39:07 -0800 (PST) From: <dillon@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_prot.c Message-ID: <200203230139.g2N1d7X88732@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Is there a reason you made this commit without :
(1) notifying me and
(2) not resolving the giant wrappers issue first.
If I recall, I explicitly asked you not to change the code
flow because I wanted to to add giant wrappers to the code.
Now, I will readily admit that the code flow in question,
in getgroups(), is utterly trivial anyway, but the point is
that you went forward with the commit without resolving
ongoing issues with me and after arbitrarily preventing me,
for four weeks, from doing a similar commit.
Your commit is basically 80% commit I wanted to do 4 weeks
ago except with some added wrappers. I am at a loss as to
why you wasted four weeks of my time stalling my commit when
you wound up committing the exact same thing, minus some
wrappers. I understand there was one issue, trivially fixed,
with p_ucred copying. That issue is in no way sufficient
to have held up my work for 4 weeks and then for you to
commit substantially the same thing.
And, in fact, my commit would also have gotten getresuid()
and getresgid() out from under Giant, which your commit hasn't
done.
-Matt
:jhb 2002/03/22 14:32:04 PST
:
: Modified files:
: sys/kern kern_prot.c
: Log:
: Use td_ucred in several trivial syscalls and remove Giant locking as
: appropriate.
:
: Revision Changes Path
: 1.146 +16 -32 src/sys/kern/kern_prot.c
:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203230139.g2N1d7X88732>