Date: Wed, 03 Jan 2007 20:45:56 +0100 From: Gabor Kovesdan <gabor@FreeBSD.org> To: Andrew Pantyukhin <infofarmer@FreeBSD.org> Cc: freebsd@alaskaparadise.com, ports@freebsd.org, Wesley Shields <wxs@atarininja.org> Subject: Re: PLIST_FILES question Message-ID: <459C07F4.5050209@FreeBSD.org> In-Reply-To: <cb5206420701031059u3b87c074kb82645afdc428b05@mail.gmail.com> References: <200701011956.14607.freebsd@alaskaparadise.com> <200701021418.18003.jonas@schiebtsich.net> <200701021327.42947.freebsd@alaskaparadise.com> <459ADFF6.9050105@FreeBSD.org> <cb5206420701031059u3b87c074kb82645afdc428b05@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrew Pantyukhin schrieb:
> On 1/3/07, Gabor Kovesdan <gabor@freebsd.org> wrote:
>> Beech Rintoul schrieb:
>> > Thanks to everyone who responded. I somehow missed that handbook
>> section, but
>> > I have it figured out now. What I needed to do is the following:
>> >
>> > .if defined(WITH_MYSQL)
>> > USE_MYSQL= yes
>> > MODULES:=${MODULES}:mod_sql:mod_sql_mysql
>> > INCLUDEDIRS:=${INCLUDEDIRS}:${LOCALBASE}/include
>> > LIBDIRS:=${LIBDIRS}:${LOCALBASE}/lib/mysql
>> > PLIST_FILES= include/proftpd/mod_sql.h
>> > .endif
>> >
>> > The extra header file is not copied to include unless that option
>> is checked
>> > and hard coding it in pkg-plist broke the pkg build. It didn't show
>> up on
>> > pointyhat because that option is off by default.
>> >
>> >
>>
>> Oh, do you want to mix PLIST_FILES and pkg-plist, did
>> I catch it right? That should not be done.
>
> Why not?
>
>> You can list that file in pkg-plist as
>> %%MYSQL%%include/proftpd/mod_sql.h and do the following in Makefile:
>>
>> if defined(WITH_MYSQL)
>> PLIST_SUB+= MYSQL=""
>> [...another things here...]
>> .else
>>
>> PLIST_SUB+= MYSQL="@comment "
>> .endif
>>
>> Look at e.g. security/amavisd-new, I do something similar there.
>
> PLIST_FILES is a bit simpler to use. Personal feelings
> about the variable, or whether it smells well when mixed
> with pkg-plist are interesting, but they are not quite
> relevant if there's no technical problem.
Well, I don't know why portlint warns you about it, but I also think it
should be avoided. I think it's just misleading. When I look at a port I
presuppose it uses either pkg-plist or PLIST_FILES, but not both, since
it is the common practise, and probably other people think in this way,
so one might overlook PLIST_FILES if one sees that pkg-plist exists.
Gabor
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?459C07F4.5050209>