Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 18 Dec 2015 17:27:55 -0800
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        cem@FreeBSD.org
Cc:        Pedro Giffuni <pfg@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r292454 - head/bin/ed
Message-ID:  <CC23C649-9CA1-44B5-8531-51F8BF2B8942@gmail.com>
In-Reply-To: <CAG6CVpWMXqzW6qBL2wE9e_ezjKF6WauMHsK-yb66yNUNvYOhaQ@mail.gmail.com>
References:  <201512182158.tBILwhRB040583@repo.freebsd.org> <44E9BE06-1883-4AF8-816D-D699CF733EEB@bsdimp.com> <DCA75AAB-5752-44E4-90B9-FC33404EA350@FreeBSD.org> <CAG6CVpWMXqzW6qBL2wE9e_ezjKF6WauMHsK-yb66yNUNvYOhaQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail 


> On Dec 18, 2015, at 15:46, Conrad Meyer <cem@FreeBSD.org> wrote:
> 
>> On Fri, Dec 18, 2015 at 2:44 PM, Pedro Giffuni <pfg@freebsd.org> wrote:
>> Hi Warner;
>> 
>>> Il giorno 18/dic/2015, alle ore 17:01, Warner Losh <imp@bsdimp.com> ha scritto:
>>> 
>>> Isnft strlcpy() the more appropriate interface? strncpy doesnft guarantee NUL termination.
>> 
>> Maybe, but we were using strcpy() which doesnft guarantee NULL termination either
>> and things have been working. I also thought that portability may be specially important
>> for the stuff in bin/.
> 
> strcpy() does guarantee NUL termination.  Otherwise it would be useless.
> 
> DESCRIPTION
>     The stpcpy() and strcpy() functions copy the string src to dst (including
>     the terminating e\0f character.)

+1 to using strlcpy instead of strcpy/strncpy.
Thanks!
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CC23C649-9CA1-44B5-8531-51F8BF2B8942>