Date: Sat, 28 May 2011 20:08:05 +0400 From: Pan Tsu <inyaoo@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@FreeBSD.ORG, freebsd-toolchain@FreeBSD.ORG Subject: Re: [rfc] a few kern.mk and bsd.sys.mk related changes Message-ID: <86oc2mlsey.fsf@gmail.com> In-Reply-To: <20110527182906.GA31871@freebsd.org> (Alexander Best's message of "Fri, 27 May 2011 18:29:06 %2B0000") References: <20110527115147.GA73802@freebsd.org> <3BF63174-1B29-4A4D-96DD-3ED65ED96EAC@bsdimp.com> <20110527181459.GA29908@freebsd.org> <20110527182906.GA31871@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Best <arundel@freebsd.org> writes: > On Fri May 27 11, Alexander Best wrote: >> On Fri May 27 11, Warner Losh wrote: >> > These look generally good. Just one thing I had a question on: >> > >> > # >> > +# Enable FreeBSD kernel-specific printf format specifiers. Also instruct gcc to >> > +# enable some diagnostics, which make it easier to pinpoint tinderbox failures. >> > +CFLAGS+= -fformat-extensions -fdiagnostics-show-option >> > + >> > >> > Does this put sand in the gears of clang support? > > i've improved the above comment so as to note that clang won't be affected by > -fdiagnostics-show-option. the new patch is available here: > > http://people.freebsd.org/~arundel/patches/kern.mk-bsy.sys.mk.patch > > another "issue" i've come across is the fact that on amd64, -O2 is always being > set, no matter, if debugging is enabled or disabled. i think amd64 should also > (just like all the other archs) be using -O, when debugging was enabled. Any reason a kernel with symbols (DEBUG) *must* be pessimized to -O1 level? Looking at r140606 it's not clear how symbols are related to a bump from -O1 to -O2 for non-amd64 archs. And -RELEASE kernels since at least 6.0R have `makeoptions DEBUG=-g' uncommented in GENERIC. > changing this is quite easy. so if people think this is something worth > changing i can integrate it into my existing patch.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86oc2mlsey.fsf>