Date: Fri, 27 Aug 2004 08:25:41 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/gettext Makefile Message-ID: <20040827152541.GB59283@dragon.nuxi.com> In-Reply-To: <20040827043857.GA16903@xor.obsecurity.org> References: <200408270116.i7R1GmiF036802@repoman.freebsd.org> <20040827043857.GA16903@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 26, 2004 at 09:38:57PM -0700, Kris Kennaway wrote:
> On Fri, Aug 27, 2004 at 01:16:48AM +0000, David E. O'Brien wrote:
> > obrien 2004-08-27 01:16:48 UTC
> >
> > FreeBSD ports repository
> >
> > Modified files:
> > devel/gettext Makefile
> > Log:
> > Add a NO_GETTEXT_OPTIONS knob.
>
> Several points:
>
> 1) You also silently removed the dependency on expat.
Sorry, this was an accident. I had it removed locally from when I was
testing if we need a dependency on 'expat'. I emailed ports last week if
anyone knew why the dependency was needed in gettext 0.13. No one has
come up with any reason yet. Nor can I find a real need for the
dependency.
Would you like me to 1. do a forced commit explaining why the depenancy
was removed, or 2. back this part out and wait a little more time to see
if someone comes up with a need for the depenancy?
> 2) User control knobs of this nature must be in the WITH_*/WITHOUT_*
> namespace, not NO_*.
I spoke to two of the "OPTIONS" authors about adding
NO_${PORTNAME}_OPTIONS and they thought it was a good idea. Neither came
back saying it should be spelled WITHOUT_${PORTNAME}_OPTIONS. Based on
your comments, I'll rename it to WITHOUT_${PORTNAME}_OPTIONS until a knob
to turn off options per-port gets implemented and committed to
bsd.port.mk.
> 3) This duplicates what BATCH does, as we discussed about a month ago.
Yes, BATCH is very global and affects all ports. This is port specific.
Much like some ports have NO_<PORTNAME>_<SOMETHING> knobs.
--
-- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040827152541.GB59283>