Date: Fri, 5 Nov 2010 20:40:08 GMT From: "Kevin Oberman" <oberman@es.net> To: gnome@FreeBSD.org Subject: Re: ports/151725: sysutils/hal: hald fails to start with dbus-1.4 Message-ID: <201011052040.oA5Ke8E2006519@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/151725; it has been noted by GNATS.
From: "Kevin Oberman" <oberman@es.net>
To: Andriy Gapon <avg@freebsd.org>
Cc: gnome@freebsd.org, bug-followup@freebsd.org
Subject: Re: ports/151725: sysutils/hal: hald fails to start with dbus-1.4
Date: Fri, 05 Nov 2010 13:32:43 -0700
> Date: Fri, 05 Nov 2010 19:33:08 +0200
> From: Andriy Gapon <avg@freebsd.org>
>
> on 05/11/2010 19:24 Andriy Gapon said the following:
> > It looked like the issue was caused by the above write() call after a sufficiently
> > quick child process had already exited.
>
> The proper patch.
>
> --- hald-runner/runner.c.orig 2010-11-05 19:26:05.673393765 +0200
> +++ hald-runner/runner.c 2010-11-05 19:26:33.471393058 +0200
> @@ -281,7 +281,7 @@ run_request_run (run_request *r, DBusCon
> }
> g_free (program_dir);
>
> - if (r->input) {
> + if (r->input && strlen(r->input) > 0) {
> if (write(stdin_v, r->input, strlen(r->input)) != (ssize_t) strlen(r->input))
> printf("Warning: Error while writing r->input (%s) to stdin_v.\n", r->input);
> close(stdin_v);
Looks like you have it! My system now runs hald with the dbus-1.4.0
without any problems.
Thanks very much, Andriy!
--
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net Phone: +1 510 486-8634
Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011052040.oA5Ke8E2006519>