Date: Fri, 17 Oct 2025 07:29:38 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Rick Macklem <rick.macklem@gmail.com> Cc: "David E. O'Brien" <obrien@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0050289464fa - main - style(9): white space after ; and around binary operators Message-ID: <16835444882475995d82a23078996276@Leidinger.net> In-Reply-To: <CAM5tNy4pCN6nUbcr9W8-%2B2MLaULDMpK_DR%2B9Yye4t6aPvrbK9Q@mail.gmail.com> References: <202510162205.59GM5ZvD042942@gitrepo.freebsd.org> <CAM5tNy68Gpj0qKV2HyRQ5t1PqchXtfi5bh53QK874aGM9WiEPw@mail.gmail.com> <CAM5tNy4pCN6nUbcr9W8-%2B2MLaULDMpK_DR%2B9Yye4t6aPvrbK9Q@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Am 2025-10-17 01:29, schrieb Rick Macklem: > On Thu, Oct 16, 2025 at 4:21 PM Rick Macklem <rick.macklem@gmail.com> > wrote: >> >> Please be aware of the following snippets from "man 9 style": >> >> In general code can be considered "new code" when it makes up about >> 50% >> or more of the file(s) involved. This is enough to break precedents in >> the existing code and use the current style guidelines. >> >> Stylistic changes (including whitespace changes) are hard on the >> source >> repository and are to be avoided without good reason. >> >> rick > Just to be clear, I am not asking that this commit be reverted. > I am just suggesting that you be aware that style(9) changes to > extant code is not, in general, encouraged, afaik unless you are > re-writing a large portion of the code (over 50%). Does someone remember why? We have now the possibility to exclude commits from the VCS attribution of lines to commits (git blame), as such, does the reason of not doing it still hold? Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmjx1FEACgkQEg2wmwP4 2IYNUA/9H8ENxveDq507XF8WH95IElosCa6Sw4NPLT6Bic/zyMq1zfMVpVcT9v17 iUq/euXpOvCmy/3NZGpXxHi1nHOHbgVaq4rBJJO9CjKxsZDd5i3tyT1i34d/rzbA m8FCdEP2Fw/vqB9g9u9mXqhqKqcgeMsHwpKJ2iKLL+I2YOfCYATT/WDBZzz1BTO6 8BkZgIPIfp1cNBUg7K+OFEPPG9xozQRxAEp7d2n2gifrmh0Z0Ng3wg9y4ntMq/DG a18vkbrDKMaT3AszOheWfYWZELvbmPLj43Zkl5DmoxOX14coSGv7irJE9N3+TDXa +kwWfvat8csMPP2BVfHMynhBQfZfSzoNXkIwgyn0TWlQyr1DHfYdkHNxu6xyhHPp egv55XtBult+1hxoiUZfEgvDlxox3DaAz86oD/dBuH2EedJXFIVsTy0EhSKsNGCN Df7/1qVxu/KyT+Gr76v2OwqDR0YRdksL6i01QZIfAOa0+dTb1jfk3fAqfVzlvvCm 59aIY9GnzRv7ZO0XeJ/90H12FQ+v7OVI02xbtMem2gmv4a3PRQYwoyRygKFfZ6Vw alAdfjRaZV6nGnGktkSzal/zsnn5jhA2CiGkrBDKck58bnpblGjY/hB7NOmAh8Hk FoMsu5ScLQDAZbXUG8PgnJ402r4a5vaAYTE7wK6qDwsSinCP3+I= =ucXA -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16835444882475995d82a23078996276>