Date: Sat, 1 Nov 2003 04:42:17 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@freebsd.org> Cc: Peter Wemm <peter@freebsd.org> Subject: Re: cvs commit: src/sys/sys cdefs.h Message-ID: <20031101043729.I1003@gamplex.bde.org> In-Reply-To: <20031031163713.GA30874@sunbay.com> References: <200310310542.h9V5gr8v023991@repoman.freebsd.org> <20031031230028.K1418@gamplex.bde.org> <20031031123129.GB777@sunbay.com> <20031101002134.Y1748@gamplex.bde.org> <20031031163713.GA30874@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 31 Oct 2003, Ruslan Ermilov wrote: > On Sat, Nov 01, 2003 at 12:34:51AM +1100, Bruce Evans wrote: > > The system shouldn't have to satisfy cleanness standards of applications > > that are not maintained by FreeBSD, especially when those standards > > are bogus (e.g., compiling cleanly with -Wundef). Hopefull all the > > important corner cases in the system headers are tested by buildworld > > so that we don't need to enlist the application maintainers to find bugs > > in system headers. > > > Now that buildworld and normal builds behave the same, I tend to agree. > Count this as "no objection" to revert this. Thanks. I think -Wsystem-headers needs to be set even when WARNS is not set (or is 0) for world builds to actually be the same (if toplev.c doesn't set it by default). Then there would be another aspect of the old problem that bsd.*.mk aren't entirely suitable for non-FreeBSD builds. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031101043729.I1003>