Date: Wed, 25 Jan 2017 17:30:05 -0600 From: "John Marino (FreeBSD)" <freebsd.contact@marino.st> To: Hiroki Sato <hrs@freebsd.org> Cc: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r431473 - in head/devel/ocaml-findlib: . files Message-ID: <91b9f4ff1e64a4a5a723bb1eb74338bd@secure.marino.st> In-Reply-To: <20170126.061245.435464315637902019.hrs@allbsd.org> References: <201701141556.v0EFuUju035888@repo.freebsd.org> <b2c7d8c9-22f1-5356-37db-436ab922bbee@marino.st> <20170126.061245.435464315637902019.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2017-01-25 15:12, Hiroki Sato wrote: > John Marino <freebsd.contact@marino.st> wrote > in <b2c7d8c9-22f1-5356-37db-436ab922bbee@marino.st>: > > fr> > +- tools/patch '@SITELIB@' '$(OCAML_SITELIB)' >findlib.conf > fr> > ++ tools/patch '@SITELIB@' '$(OCAML_SITELIB):$(OCAML_LIBDIR)' > fr> > >findlib.conf > fr> > + if ./tools/cmd_from_same_dir ocamlc; then \ > fr> > + echo 'ocamlc="ocamlc.opt"' >>findlib.conf; \ > fr> > + fi > fr> > fr> > fr> I think this change is the direct cause for math/ocaml-zarith > failing > fr> on all platforms. It's expecting a single directory, not a > fr> concatenated series of directories. > fr> > fr> What was this change supposed to address? > > Oh, I did not notice the multiple directory specification broke > math/ocaml-zarith. It was because some ocaml libraries use > OCAML_LIBDIR as the installation directory and findlib does not find > them on runtime. The problem is that a wrong directory is used in > some ports. I am working on fixing devel/ocaml-* ports after this > commit and eventually the change in question will be removed. I will > take care of math/ocaml-zarith, too. by the way, this change broke textproc/ocaml-pxp and x11-toolkits/ocaml-lablgtk2 too, but madpilot@ already patched that port to strip out the second path. It's possible several ocaml ports were broken by it. Thanks for taking care of ocaml-zarith, and maybe ocaml-pxp too. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?91b9f4ff1e64a4a5a723bb1eb74338bd>