Date: Sat, 26 Feb 2005 17:27:15 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/powerd powerd.c Message-ID: <dd7e92aaed40eb45637efb2a2465c6a6@xcllnt.net> In-Reply-To: <42211F1D.30801@root.org> References: <20050227002323.AEFC716A55A@hub.freebsd.org> <42211F1D.30801@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Feb 26, 2005, at 5:15 PM, Nate Lawson wrote: > Marcel Moolenaar wrote: >> marcel 2005-02-27 00:23:19 UTC >> FreeBSD src repository >> Modified files: >> usr.sbin/powerd powerd.c Log: >> Unbreak !i386 platforms. Only i386 has APM, so don't try to fallback >> on APM on other platforms. >> Revision Changes Path >> 1.3 +11 -1 src/usr.sbin/powerd/powerd.c > > Thanks. It would be cleaner to move this code into apm_init_ac() and > acpm_get_ac() functions so the ifdef could be in just one place. Agreed. That would also make it easier to have powerd(8) on platforms that have neither APM nor ACPI, but have something else (possibly). > I think there is also one other issue. It would be cleaner to check > for the acpi sysctl in the rc.d script and return immediately rather > than starting powerd and it bombing out once it discovers this. I'm not sure. I think PowerPC will benefit if powerd(8) grows support for wharever is present there. In that light, it makes sense to treat powerd(8) as a generic service and thus have it started unconditionally. Just a thought, -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dd7e92aaed40eb45637efb2a2465c6a6>