Date: Fri, 16 Dec 2016 16:22:43 -0600 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Baptiste Daroussin <bapt@FreeBSD.org>, "Conrad E. Meyer" <cem@FreeBSD.org>, Dimitry Andric <dim@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310138 - head/lib/libc/stdio Message-ID: <6b3b39af-467f-087e-261f-db80e027276e@FreeBSD.org> In-Reply-To: <1481918834.1972.77.camel@freebsd.org> References: <201612160144.uBG1ipjW016736@repo.freebsd.org> <20161216193128.wgskqt4vc44vdd7o@ivaldir.etoilebsd.net> <1481918834.1972.77.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/16/2016 14:07, Ian Lepore wrote: > On Fri, 2016-12-16 at 20:31 +0100, Baptiste Daroussin wrote: >> On Fri, Dec 16, 2016 at 01:44:51AM +0000, Conrad E. Meyer wrote: >>> >>> Author: cem >>> Date: Fri Dec 16 01:44:50 2016 >>> New Revision: 310138 >>> URL: https://svnweb.freebsd.org/changeset/base/310138 >>> >>> Log: >>> vfprintf(3): Add support for kernel %b format >>> >>> This is a direct port of the kernel %b format. >>> >>> I'm unclear on if (more) non-portable printf extensions will be a >>> problem. I think it's desirable to have userspace formats include >>> all >>> kernel formats, but there may be competing goals I'm not aware >>> of. >>> >>> Reviewed by: no one, unfortunately >>> Sponsored by: Dell EMC Isilon >>> Differential Revision: https://reviews.freebsd.org/D8426 >>> >> I really don't think it is a good idea, if used in userland it would >> be make >> more of our code difficult to port elsewhere. >> >> Other than that, it makes more difficult to use vanilla gcc with out >> userland. >> and it is adding more complexity to be able to build freebsd from a >> non freebsd >> system which some people are working on. >> >> Personnaly I would prefer to see those extensions removed from the >> kernel rather >> than see them available in userland. >> >> Can't we use simple helper function instead? >> >> Best regards, >> Bapt > > I'll add a big +1 for the concept of eliminating the extensions from > the kernel instead of extending them to userland. People ask why > freebsd can't be built using standard tools on foreign build hosts, and > these non-standard extensions are part of the reason why. I strongly agree. Thanks for mentioning snprintb, Dimitry; I hadn't seen that one. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6b3b39af-467f-087e-261f-db80e027276e>