Date: Thu, 7 Nov 2019 12:50:34 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354477 - in head/sys: netinet netinet6 Message-ID: <20191107205034.GQ2195@FreeBSD.org> In-Reply-To: <201911072049.xA7Knu4I072521@repo.freebsd.org> References: <201911072049.xA7Knu4I072521@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 07, 2019 at 08:49:56PM +0000, Gleb Smirnoff wrote: T> Author: glebius T> Date: Thu Nov 7 20:49:56 2019 T> New Revision: 354477 T> URL: https://svnweb.freebsd.org/changeset/base/354477 T> T> Log: T> Since r353292 on input path we are always in network epoch, when T> we lookup PCBs. Thus, do not enter epoch recursively in T> in_pcblookup_hash() and in6_pcblookup_hash(). Same applies to T> tcp_ctlinput() and tcp6_ctlinput(). T> T> This leaves several sysctl(9) handlers that return PCB credentials T> unprotected. Add epoch enter/exit to all of them. T> T> Differential Revision: https://reviews.freebsd.org/D22197 Note: only this commit references the differential revision, as it is the core change. But preceeding commits and following commits related to PCB locking were all part of this review. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191107205034.GQ2195>