Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Feb 2025 15:53:46 GMT
From:      Cy Schubert <cy@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 628715fdcc9f - main - ntp: NULL pointer deref when create_interface() fails
Message-ID:  <202502281553.51SFrkfQ099044@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by cy:

URL: https://cgit.FreeBSD.org/src/commit/?id=628715fdcc9f2226bfe0f4ebe381aaa7761cb6cc

commit 628715fdcc9f2226bfe0f4ebe381aaa7761cb6cc
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2025-02-28 15:46:23 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2025-02-28 15:53:22 +0000

    ntp: NULL pointer deref when create_interface() fails
    
    Fix NULL pointer dereference when create_interface() fails in
    update_interfaces(). The upstream bug report says a typo was introduced
    by https://bk.ntp.org/ntp-dev/ntpd/ntp_io.c?PAGE=diffs&REV=66175036PETA6g__fON8oNrjL54Ttw. ep should have been ep2.
    
    Fix obtained from upstream bug report.
    
    PR:             285065
    Upstream bug:   https://bugs.ntp.org/show_bug.cgi?id=3939
    MFC after:      1 minute
---
 contrib/ntp/ntpd/ntp_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c
index 6a796101b0e8..9c4f6c1553e3 100644
--- a/contrib/ntp/ntpd/ntp_io.c
+++ b/contrib/ntp/ntpd/ntp_io.c
@@ -1919,7 +1919,7 @@ update_interfaces(
 		}
 		else {
 			DPRINT_INTERFACE(3,
-				(ep, "updating ", " new - FAILED"));
+				(ep2, "updating ", " new - FAILED"));
 
 			msyslog(LOG_ERR,
 				"cannot bind address %s",



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502281553.51SFrkfQ099044>